On Fri, May 26, 2017 at 12:55:22PM -0400, Dennis Dalessandro wrote: > On 5/26/2017 12:35 PM, Saeed Mahameed wrote: > > On Fri, May 26, 2017 at 3:56 PM, Dennis Dalessandro > > <dennis.dalessandro@xxxxxxxxx> wrote: > > > On 5/23/2017 7:44 AM, Saeed Mahameed wrote: > > > Anyway i don't think we are going to change this frequently or even use it. > > > But if you are that much against touching this ethtool field, why > > don't you just jump into the mud and remove it from the tree, I > > imagine it is really hard for you to watch for patches doing this and > > nack them on the list. > > I have no interest in policing that. I complained about the other driver > because I know patches like that were NAKed by Greg KH in the past (ours). > I'd rather not see the rdma subsystem keep making the same mistakes is all. > We want to improve our standing in the community after all. As I said I'm > not personally against it as evidenced by our driver. I personally would like to see patch which does two things: 1. Removes all these MODULE_VERSIONS 2. Puts some hardcoded value common to kernel, so no user space application (like modinfo) won't be broken. > > > > I realize Dave has already pulled this and I'm not asking for it to be > > > reverted but maybe some discussion will help guide future patch submissions > > > which do this stuff. > > > > > > > Sure, although i don't think we are going to use those version fields > > in the future, > > please allow me to ask, how do you do your driver versioning ? how do > > you track things ? > > and what is your future vision regarding ethool->drv_version ? > > That's just the thing, we don't do anything with it either really. I'm > trying to justify its existence to myself and if you folks had some whiz > bang idea for a driver version I was interested in hearing what it was. No, we didn't find any real usage of it too. My attempts raise attention to that issue in netdev weren't successful, maybe you will have more luck than me. https://lkml.org/lkml/2016/7/15/17 https://patchwork.kernel.org/patch/9349357/ Thanks > > -Denny > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
signature.asc
Description: PGP signature
