On 5/23/2017 7:44 AM, Saeed Mahameed wrote:
From: Tariq Toukan <tariqt@xxxxxxxxxxxx> Remove date and bump version for mlx5_core driver. Signed-off-by: Tariq Toukan <tariqt@xxxxxxxxxxxx> Signed-off-by: Saeed Mahameed <saeedm@xxxxxxxxxxxx>
So I just complained about the bnxt_re doing this. I guess I need to raise a flag here too. Now to be clear I'm not against doing this version stuff. I'm against using it for some internal tracking that is meaningless to the kernel community.
There is no detail in your commit message as to what this driver version is used for. Can you please explain how your use of driver version is valid while theirs is not?
I realize Dave has already pulled this and I'm not asking for it to be reverted but maybe some discussion will help guide future patch submissions which do this stuff.
-Denny -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html