Re: [PATCH] infiniband: hw: cxgb4: Use AF_INET for sin_family field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 24, 2016 at 07:14:35AM +0530, Shyam Saini wrote:
> Elsewhere the sin_family field holds a value with a name of the form
> AF_..., so it seems reasonable to do so here as well.  Also the values
> of PF_INET and AF_INET are the same.
>
> The semantic patch that makes this change is as follows:
>
> //</smpl>
> @@
> struct sockaddr_in sip;
> @@
>
> (
> sip.sin_family ==
> - PF_INET
> + AF_INET
> |
> sip.sin_family !=
> - PF_INET
> + AF_INET
> |
> sip.sin_family =
> - PF_INET
> + AF_INET
> )
> //</smpl>
>
> Signed-off-by: Shyam Saini <mayhs11saini@xxxxxxxxx>
> ---
>  drivers/infiniband/hw/cxgb4/cm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>

>
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index f1510cc..9749c52 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -2516,18 +2516,18 @@ static int pass_accept_req(struct c4iw_dev *dev, struct sk_buff *skb)
>  		struct sockaddr_in *sin = (struct sockaddr_in *)
>  			&child_ep->com.local_addr;
>
> -		sin->sin_family = PF_INET;
> +		sin->sin_family = AF_INET;
>  		sin->sin_port = local_port;
>  		sin->sin_addr.s_addr = *(__be32 *)local_ip;
>
>  		sin = (struct sockaddr_in *)&child_ep->com.local_addr;
> -		sin->sin_family = PF_INET;
> +		sin->sin_family = AF_INET;
>  		sin->sin_port = ((struct sockaddr_in *)
>  				 &parent_ep->com.local_addr)->sin_port;
>  		sin->sin_addr.s_addr = *(__be32 *)local_ip;
>
>  		sin = (struct sockaddr_in *)&child_ep->com.remote_addr;
> -		sin->sin_family = PF_INET;
> +		sin->sin_family = AF_INET;
>  		sin->sin_port = peer_port;
>  		sin->sin_addr.s_addr = *(__be32 *)peer_ip;
>  	} else {
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux