On 05/18/2016 10:26 AM, Mark Bloch wrote: > > >> -----Original Message----- >> From: Doug Ledford [mailto:dledford@xxxxxxxxxx] >> Sent: Wednesday, May 18, 2016 5:17 PM >> To: Mark Bloch <markb@xxxxxxxxxxxx>; leon@xxxxxxxxxx >> Cc: linux-rdma@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH rdma-next V2 5/5] IB/core: Integrate IB address >> resolution module into core >> > [snip] >> Unless you went back to your original first patch set where ib_netlink >> was a separate module, then the load order could be ib_netlink -> >> ib_addr -> ib_core and things would work. Possibly. Depends on whether >> the ib_netlink module has anything in it that references symbols in ib_core. > Yes, the first version did just that and worked, but then there were > comments that we have too many modules and I shouldn't add another one. > > V0 adds a new kernel module (ib_netlink.ko ) but leaves ib_core and ib_addr > modules unchanged. I also have a version with Leon's patch > that eliminates ib_addr.ko and doesn't add a new module. > > Would you like me to submit a new version (with Leon's patch) or the review can continue with V0? One of the things that has come about as a result of this conversation is that EL6 is the only distro to provide the reload capability. I have the ability to make sure it gets updated to account for the module change, so let's move forward with a version that removes ib_addr and moves it into the ib_core and also keep the new ib_netlink stuff in ib_core. So, fewer modules, not more. -- Doug Ledford <dledford@xxxxxxxxxx> GPG KeyID: 0E572FDD
Attachment:
signature.asc
Description: OpenPGP digital signature
