I believe Paolo is planning to look next week. No idea why the patch got marked as Accepted 🤷️ On Fri, 3 Feb 2023 12:05:56 -0800 Saeed Mahameed wrote: > I don't agree, RDMA isn't proprietary, and I wish not to go into this > political discussion, as this series isn't the right place for that. I don't think it's a political discussion. Or at least not in the sense of hidden agendas because our agendas aren't hidden. I'm a maintainer of an open source networking stack, you're working for a vendor who wants to sell their own networking stack. Perhaps you'd like to believe, and importantly have your customers believe that it's the same networking stack. It is not, the crucial, transport part of your stack is completely closed. I don't think we can expect Linus to take a hard stand on this, but do not expect us to lend you our APIs and help you sell your product. Saying that RDMA/RoCE is not proprietary because there is a "standard" is like saying that Windows is an open source operating system because it supports POSIX. My objectives for netdev are: - give users vendor independence - give developers the ability to innovate I have not seen an RDMA implementation which could deliver on either. Merging this code is contrary to my objectives for the project. > To summarize, mlx5_core is doing RoCE traffic processing and directs it to > mlx5_ib driver (a standard rdma stack), in this series we add RoCE ipsec > traffic processing as we do for all other RoCE traffic. I already said it. If you wanted to configure IPsec for RoCE you should have added an API in the RDMA subsystem.