On Thu, Feb 02, 2023 at 09:54:53AM -0800, Jakub Kicinski wrote: > On Thu, 2 Feb 2023 13:44:05 -0400 Jason Gunthorpe wrote: > > > You don't remember me trying to convince you to keep the RoCE stuff > > > away from our open source IPsec implementation? > > > > Huh? What does this: > > > > https://lore.kernel.org/all/cover.1673960981.git.leon@xxxxxxxxxx/ > > > > Have to do with IPsec? > > Dunno. But I don't know what it has to do with the PR we're commenting > on either.. It has to do, because I need shared branch to put net/mlx5 patches from that "special keys" series and I patiently waited for any response. First, I didn't see any comment of not pulling Saeed's PR. Second, I didn't see any not-pulling comments other IPsec patches which Saeed posted prior issuing his PR. Third, IPsec patches are pure mlx5_core changes. This is where flow steering exists. ➜ kernel git:(rdma-next) git diff --stat bb2e8913dc40..ml/mlx5-next drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +- drivers/net/ethernet/mellanox/mlx5/core/diag/fs_tracepoint.c | 4 + drivers/net/ethernet/mellanox/mlx5/core/en/fs.h | 1 + drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h | 1 + drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c | 59 ++++++-- drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.c | 6 + drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 44 +++++- drivers/net/ethernet/mellanox/mlx5/core/lib/ipsec_fs_roce.c | 372 +++++++++++++++++++++++++++++++++++++++++++++++++ drivers/net/ethernet/mellanox/mlx5/core/lib/ipsec_fs_roce.h | 20 +++ include/linux/mlx5/fs.h | 3 + 10 files changed, 497 insertions(+), 15 deletions(-) Thanks