From: Paul Mackerras <paulus@xxxxxxxxx>
Date: Sat, 8 Jan 2011 14:13:20 +1100
> On Fri, Jan 07, 2011 at 05:15:34PM -0800, David Miller wrote:
>
>> I have to say that every time I go read the header parsing code in the
>> PPP driver, I absolutely regret it.
>>
>> And Changli's patch fixes some of the readability problems.
>
> It's up to you whether you merge the patch or not, but surely you
> agree it needs more than a zero-line description?
It's entire sufficient to me.
He de-open-coded {get,put}_unaligned_be{16,32}() and when open-coding
is eliminated in this way a commit message of "Use {helper function
foo}." is more than enough.
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
