From: Changli Gao <xiaosuo@xxxxxxxxx> Date: Sat, 8 Jan 2011 08:43:01 +0800 > On Fri, Jan 7, 2011 at 11:01 AM, Paul Mackerras <paulus@xxxxxxxxx> wrote: >> On Fri, Jan 07, 2011 at 07:37:36AM +0800, Changli Gao wrote: >> >>> Signed-off-by: Changli Gao <xiaosuo@xxxxxxxxx> >> >> This patch description is inadequate. It should tell us why you are >> making this change. Does it result in smaller and/or faster code, and >> if so by how much on what sort of machine? Do you think it makes the >> code clearer? (I don't.) Or is there some other motivation for this? >> > > Good designed APIs always make code clearer, smaller and faster. It is > obvious enough I think. I have to say that every time I go read the header parsing code in the PPP driver, I absolutely regret it. And Changli's patch fixes some of the readability problems. -- To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
