On Fri, Jan 07, 2011 at 05:15:34PM -0800, David Miller wrote: > I have to say that every time I go read the header parsing code in the > PPP driver, I absolutely regret it. > > And Changli's patch fixes some of the readability problems. It's up to you whether you merge the patch or not, but surely you agree it needs more than a zero-line description? Paul. -- To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html