Re: [PATCH] mrst_pmu: driver for Intel Moorestown Power Management Unit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 01 Aug 2011 11:24:45 -0400 (EDT)
Len Brown <lenb@xxxxxxxxxx> wrote:

> 
> > > +	BUG_ON(pci_dev_num != mrst_devs[index].pci_dev_num);
> > 
> > That strikes me as needlessly unfriendly, you could warn/return NULL and
> > propogate a WARN_ONCE back to the user.
> 
> If a fit of friendlyness, I wrote the patch below.
> Let me know if it is not what you had in mind.

It's not so much the bug on as the fact it spews these if you boot it on
a non mrst box built with a generic kernel - which was the second part of
my comment and doesn't appear addressed.
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm


[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux