The intel_idle driver defines power consumption for all states, but
they can't be seen in sysfs because the driver doesn't set
dev->power_specified, while the idle code expects that.
Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
Cc: Len Brown <lenb@xxxxxxxxxx>
---
This is the simple fix. But in all honesty, I don't get the point of
dev->power_specified. It should be equally easy to check if the first
state's .power has a non-zero value, and at least this doesn't require
any cooperation from the driver. As it stands, I expect that future
drivers will have the same problem intel_idle had, i.e. they will
forget to set dev->power_specified and power consumption values
won't be visible in syfs.
Am I missing any obvious problem? If not, I'll be happy to provide an
alternative patch dropping dev->power_specified altogether.
drivers/idle/intel_idle.c | 1 +
1 file changed, 1 insertion(+)
--- linux-2.6.36-rc7.orig/drivers/idle/intel_idle.c 2010-10-07 08:53:05.000000000 +0200
+++ linux-2.6.36-rc7/drivers/idle/intel_idle.c 2010-10-08 16:16:41.000000000 +0200
@@ -369,6 +369,7 @@ static int intel_idle_cpuidle_devices_in
dev->state_count += 1;
}
+ dev->power_specified = 1;
dev->cpu = i;
if (cpuidle_register_device(dev)) {
pr_debug(PREFIX "cpuidle_register_device %d failed!\n",
--
Jean Delvare
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm
