Re: [PATCH v4 2/2] PCI: rcar: Fix missing MACCTLR register setting in initialize sequence

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lorenzo,

On Tue, Nov 12, 2019 at 11:27 AM Lorenzo Pieralisi
<lorenzo.pieralisi@xxxxxxx> wrote:
> On Tue, Nov 12, 2019 at 01:48:03AM +0000, Yoshihiro Shimoda wrote:
> > I'm sorry. I think I should not drop a sentence "because the bit 0 is
> > set to 1 on reset" which has the reverted patch from this version. Also,
> > the note seems to be difficult to understand. So, I'll rewrite this log
> > like below. Is it acceptable?
> >
> > ---
> > According to the R-Car Gen2/3 manual,
>
> Is this a publicly available manual ? If yes we provide a link, if
> not I will reword the sentence below.

The same hardware block is present in the RZ/G series, and documented
in RZ/G Series User's Manual: Hardware
https://www.renesas.com/eu/en/products/microcontrollers-microprocessors/rz/rzg/rzg1m.html#documents
Chapter 39 ("PCIEC").
Section 39.28.98 ("MAC Control Register (MACCTLR)")
Section 39.3.1 ("Initialization"), Paragraph 3 ("Initial Setting of
PCI Express").

Thanks, and happy digesting ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux