On Thu, May 09, 2019 at 08:39:28PM +0300, Andy Shevchenko wrote: > On Thu, May 9, 2019 at 5:18 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > Log messages with pci_dev, not pcie_device. Factor out common message > > prefixes with dev_fmt(). > > > > Example output change: > > > > - dpc 0000:00:01.1:pcie008: DPC error containment capabilities... > > + pcieport 0000:00:01.1: DPC: error containment capabilities... > > Overall same question about Capitalizing sentences. I think that consistency would be nice. But I'm not sure whether the consensus is capitalize or not, and I would want to do all of drivers/pci in a single patch so there's a clear precedent to follow, so I think that's slightly out of scope for this series. > > + pci_err(pdev, "rp_pio_status: %#010x, rp_pio_mask: %#010x\n", > > And here perhaps RP PIO status: ... mask: ... ? > See below I left examples from this patch. Same thing here. I noticed this as well, but didn't want to pollute these patches with other cleanups that were not really related, so this could be done in the future. But I certainly agree it's weird to have "rp_pio_status:" and "RP PIO severity=". > > status, mask); > > > + pci_err(pdev, "RP PIO severity=%#010x, syserror=%#010x, exception=%#010x\n", > > sev, syserr, exc); > > > + pci_err(pdev, "RP PIO ImpSpec Log %#010x\n", log); > > > + pci_err(pdev, "RP PIO log size %u is invalid\n", > > dpc->rp_log_size); > > -- > With Best Regards, > Andy Shevchenko
