On Thu, May 09, 2019 at 11:31:04AM -0700, Joe Perches wrote: > On Thu, 2019-05-09 at 20:35 +0300, Andy Shevchenko wrote: > > On Thu, May 9, 2019 at 5:18 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > > Replace dev_printk(KERN_DEBUG) with dev_info() or dev_err() to be more > > > consistent with other logging. > > > > > > These could be converted to dev_dbg(), but that depends on > > > CONFIG_DYNAMIC_DEBUG and DEBUG, and we want most of these messages to > > > *always* be in the dmesg log. > > > > > > Also, use dev_fmt() to add the service name. Example output change: > > > > > > - pcieport 0000:80:10.0: Signaling PME with IRQ ... > > > + pcieport 0000:80:10.0: PME: Signaling with IRQ ... > > > + pci_info(port, "interrupt generated for non-existent device %02x:%02x.%d\n", > > > + busnr, PCI_SLOT(devfn), PCI_FUNC(devfn)); > > > + pci_info(port, "Spurious native interrupt!\n"); > > > + pci_info(port, "Signaling with IRQ %d\n", srv->irq); > > Why change the logging level? > Why not use #define DEBUG and use pci_dbg ? What would the benefit of using DEBUG be? I don't want these particular messages to be conditional. For messages that *should* be conditional, there's a later patch in the series to use pci_dbg() and convert them to dyndbg so we have a single mechanism for turning them off/on. Bjorn
