On Thu, May 09, 2019 at 08:42:10PM +0300, Andy Shevchenko wrote: > On Thu, May 9, 2019 at 5:19 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > Log messages with pci_dev, not pcie_device. Factor out common message > > prefixes with dev_fmt(). > > > > Example output change: > > > > - aer 0000:00:00.0:pci002: AER enabled with IRQ ... > > + pcieport 0000:00:00.0: AER: enabled with IRQ ... > > > + pci_err(port, "request AER IRQ %d failed\n", > > dev->irq); > > Possible to be on one line? Yep, fixed this in a previous patch. > > + pci_warn(edev->port, > > + "AER service is not initialized\n"); > > checkpatch won't complain if it would be on one line. Right, thanks, fixed this too. Bjorn
