Re: [PATCH 1/4] PCI: Replace dev_*() printk wrappers with pci_*() printk wrappers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andy,

Andy Shevchenko wrote on 4/28/19 10:43 AM:
On Sat, Apr 27, 2019 at 02:13:01PM -0500, fred@xxxxxxxxxxxx wrote:
From: Frederick Lawler <fred@xxxxxxxxxxxx>

Replace remaining instances of dev_*() printk wrappers with pci_*()
printk wrappers. No functional change intended.

-		pci_printk(KERN_DEBUG, parent, "can't find device of ID%04x\n",
-			   e_info->id);
+		pci_dbg(parent, "can't find device of ID%04x\n", e_info->id);

These are not equivalent.

-		dev_printk(KERN_DEBUG, device, "alloc AER rpc failed\n");
+		pci_dbg(pdev, "alloc AER rpc failed\n");

Ditto.

-		dev_printk(KERN_DEBUG, device, "request AER IRQ %d failed\n",
-			   dev->irq);
+		pci_dbg(pdev, "request AER IRQ %d failed\n", dev->irq);

Ditto.

And so on.


Thanks for the review. Clearly this was an oversight on my part and I'll have that corrected. Thanks!


Frederick Lawler




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux