Re: [PATCH v7 0/7] Add virtio-iommu driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jean,

On 15.01.2019 13:19, Jean-Philippe Brucker wrote:
> Implement the virtio-iommu driver, following specification v0.9 [1].
> 
> This is a simple rebase onto Linux v5.0-rc2. We now use the
> dev_iommu_fwspec_get() helper introduced in v5.0 instead of accessing
> dev->iommu_fwspec, but there aren't any functional change from v6 [2].
> 
> Our current goal for virtio-iommu is to get a paravirtual IOMMU working
> on Arm, and enable device assignment to guest userspace. In this
> use-case the mappings are static, and don't require optimal performance,
> so this series tries to keep things simple. However there is plenty more
> to do for features and optimizations, and having this base in v5.1 would
> be good. Given that most of the changes are to drivers/iommu, I believe
> the driver and future changes should go via the IOMMU tree.
> 
> You can find Linux driver and kvmtool device on v0.9.2 branches [3],
> module and x86 support on virtio-iommu/devel. Also tested with Eric's
> QEMU device [4]. Please note that the series depends on Robin's
> probe-deferral fix [5], which will hopefully land in v5.0.
> 
> [1] Virtio-iommu specification v0.9, sources and pdf
>      git://linux-arm.org/virtio-iommu.git virtio-iommu/v0.9
>      http://jpbrucker.net/virtio-iommu/spec/v0.9/virtio-iommu-v0.9.pdf
> 
> [2] [PATCH v6 0/7] Add virtio-iommu driver
>      https://lists.linuxfoundation.org/pipermail/iommu/2018-December/032127.html
> 
> [3] git://linux-arm.org/linux-jpb.git virtio-iommu/v0.9.2
>      git://linux-arm.org/kvmtool-jpb.git virtio-iommu/v0.9.2
> 
> [4] [RFC v9 00/17] VIRTIO-IOMMU device
>      https://www.mail-archive.com/qemu-devel@xxxxxxxxxx/msg575578.html
> 
> [5] [PATCH] iommu/of: Fix probe-deferral
>      https://www.spinics.net/lists/arm-kernel/msg698371.html
> 
> Jean-Philippe Brucker (7):
>    dt-bindings: virtio-mmio: Add IOMMU description
>    dt-bindings: virtio: Add virtio-pci-iommu node
>    of: Allow the iommu-map property to omit untranslated devices
>    PCI: OF: Initialize dev->fwnode appropriately
>    iommu: Add virtio-iommu driver
>    iommu/virtio: Add probe request
>    iommu/virtio: Add event queue
> 
>   .../devicetree/bindings/virtio/iommu.txt      |   66 +
>   .../devicetree/bindings/virtio/mmio.txt       |   30 +
>   MAINTAINERS                                   |    7 +
>   drivers/iommu/Kconfig                         |   11 +
>   drivers/iommu/Makefile                        |    1 +
>   drivers/iommu/virtio-iommu.c                  | 1158 +++++++++++++++++
>   drivers/of/base.c                             |   10 +-
>   drivers/pci/of.c                              |    7 +
>   include/uapi/linux/virtio_ids.h               |    1 +
>   include/uapi/linux/virtio_iommu.h             |  161 +++
>   10 files changed, 1449 insertions(+), 3 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/virtio/iommu.txt
>   create mode 100644 drivers/iommu/virtio-iommu.c
>   create mode 100644 include/uapi/linux/virtio_iommu.h
> 

I have tested the whole series and Eric's QEMU patchset [4] for 
virtio-net-pci and virtio-blk-pci devices and faced no issues on 
ThunderX2. The multiqueue mode for both devices is working fine too so:

Tested-by: Tomasz Nowicki <tnowicki@xxxxxxxxxxx>

Thanks,
Tomasz




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux