Re: [PATCH V2] PCI: rcar: Add the initialization of PCIe link in resume_noirq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 19, 2019 at 06:24:20PM +0100, Wolfram Sang wrote:
> On Sun, Feb 17, 2019 at 02:24:41PM +0100, marek.vasut@xxxxxxxxx wrote:
> > From: Kazufumi Ikeda <kaz-ikeda@xxxxxxxxxxxxx>
> > 
> > Reestablish the PCIe link very early in the resume process in case it
> > went down to prevent PCI accesses from hanging the bus. Such accesses
> > can happen early in the PCI resume process, in the resume_noirq, thus
> > the link must be reestablished in the resume_noirq callback of the
> > driver.
> > 
> > Signed-off-by: Kazufumi Ikeda <kaz-ikeda@xxxxxxxxxxxxx>
> > Signed-off-by: Gaku Inami <gaku.inami.xw@xxxxxxxxxxxxxx>
> > Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
> 
> I am not a deep PCI expert. Still, the patch looks good to me and I
> double checked with the documentation.
> 
> Acked-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> 
> Minor nit would be 'CONFIG_PM' protection around the new code. But I
> have no strong opinion on that.

I agree that would be a nice enhancement but I also do not feel strongly
about it.

Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux