Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 20, 2018 at 09:43:48PM +0530, poza@xxxxxxxxxxxxxx wrote:
> On 2018-08-20 21:23, Keith Busch wrote:
> > On Mon, Aug 20, 2018 at 09:22:27PM +1000, Benjamin Herrenschmidt wrote:
> > > The main problem with unplug/replug (as I mentioned earlier) is that
> > > it
> > > just does NOT work for storage controllers (or similar type of
> > > devices). The links between the storage controller and the mounted
> > > filesystems is lost permanently, you'll most likely have to reboot the
> > > machine.
> > 
> > You probably shouldn't mount raw storage devices if they can be hot
> > added/removed. There are device mappers for that! :)
> > 
> > And you can't just change DPC device removal. A DPC event triggers
> > the link down, and that will trigger pciehp to disconnect the subtree
> > anyway. Having DPC do it too just means you get the same behavior with
> > or without enabling STLCTL.DLLSC.
> 
> Hi Keith,
> 
> what about the bridges which are not hotplug capable ?

That would have to mean SLTCTL.DLSSC isn't enabled. The point was to
make DPC control behave the same regardless of slot control.



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux