On 2018-08-20 07:33, Benjamin Herrenschmidt wrote:
On Sun, 2018-08-19 at 17:41 -0400, Sinan Kaya wrote:
On 8/18/2018 10:19 PM, Bjorn Helgaas wrote:
> > Bjorn, please revert all of those changes.
>
> Please send the appropriate patches and we'll go from there.
>
I'm also catching up on this thread.
I don't think revert is the way to go. There is certainly value in
Oza's
code to make error handling common.
The revert of the Documentation change must happen though. It's
completely wrong. The documentation documents what EEH implements so by
making it match what I argue is a broken implementation in AER, you are
in fact breaking us.
We started by following the existing error handling scheme and then
moved onto the stop/remove behavior based on Bjorn's feedback.
Whish is utterly wrong.
The right thing is for Oza to rework the code to go back to original
error handling callback mechanism. That should be a trivial change.
At this stage I'm only asking to revert the documentation updatgae.
I'll send a patch to that effect.
As for figuring out where to go from there, I agree we should discuss
this further, I would love to be able to make more of the code common
with EEH as well.
Cheers,
Ben.
Reverting spec/Documentation which is fine by me.
But the good thing has happened now is; we can have very clear
definition for the framework to go forward.
e.g. how the errors have to be handled.
Because of those patches, the whole error framework is under common code
base and now has become independent of service e.g. AER, DPC etc..
That enables us to define or extend policies in more clearly defined way
irrespective of what services are running.
Now it is just that we have to change in err.c and walk away with the
policies what we want to enforce.
let me know how this sounds Ben.
Regards,
Oza.
