On 2018-08-20 21:23, Keith Busch wrote:
On Mon, Aug 20, 2018 at 09:22:27PM +1000, Benjamin Herrenschmidt wrote:
The main problem with unplug/replug (as I mentioned earlier) is that
it
just does NOT work for storage controllers (or similar type of
devices). The links between the storage controller and the mounted
filesystems is lost permanently, you'll most likely have to reboot the
machine.
You probably shouldn't mount raw storage devices if they can be hot
added/removed. There are device mappers for that! :)
And you can't just change DPC device removal. A DPC event triggers
the link down, and that will trigger pciehp to disconnect the subtree
anyway. Having DPC do it too just means you get the same behavior with
or without enabling STLCTL.DLLSC.
Hi Keith,
what about the bridges which are not hotplug capable ?
Besides, following patch is trying to ignore link event if there is
fatal error reporting.
[PATCH v8 1/2] PCI: pciehp: Ignore link events when there is a fatal
error pending
Regards,
Oza.
