On 8/6/2018 12:49 PM, Sinan Kaya wrote:
Surprise Link Down is also a fatal error.
Seriously? On a Downstream Port which has the Hot-Plug Surprise bit
in the Slot Capabilities register set, Surprise Link Down is a fatal
error? That would seem somewhat contradictory. Do you have a
section number in the PCIe Base Spec for this?
Spec 3.0. 7.10.2. Uncorrectable Error Status Register (Offset 04h)
bit 5 Surprise Down Error Status (Optional).
I think hotplug surprise capability takes priority over the one in AER
register. Other non-hotplug capable systems can report a link down via
AER Fatal error and recover via the error handling path.
We should maybe leave this one alone since hotplug code wouldn't clear
the AER status registers.