On Fri, Jun 08, 2018 at 03:12:00PM -0500, Bjorn Helgaas wrote: > The portdrv code is scattered across several files, which makes it a bit of > a hassle to browse. Consolidate it all in a single file. Why? By that logic we could concatinate the whole kernel into a single file. The rationale of splitting into multiple files is to separate distinct components. In the case of portdrv, this means separating the portion that interfaces with the PCI core (for the port's pci_dev) from the portion that interfaces with the service drivers. It does happen over time that the distinct purpose of each file gets blurred, necessitating a reorg to once again achieve a clean separation of orthogonal driver portions. Of course that's more work than just putting everything into one file. Please also keep in mind that putting everything into one file just because you can creates a lot of additional, unneccessary rebasing work for all contributors to that code. Thanks, Lukas
