On Fri, Jun 08, 2018 at 02:17:13PM -0600, Keith Busch wrote: > On Fri, Jun 08, 2018 at 03:05:41PM -0500, Bjorn Helgaas wrote: > > The aer_irq() declaration is the only thing needed by aer_inject.c. Move > > it to portdrv.h so we eventually get rid of aerdrv.h completely. No > > functional change intended. > > Nothing against what you're doing here, but it does seem odd that aer_irq > is required to be exported just for the error injection to directly call > it. I feel like aer-inject should route it through the irq subsystem, > like with generic_handle_irq. ? I totally agree, that's ugly, but I don't have a good idea for how to fix it yet. (And I don't want to do anything more than the simplest possible code moves at this stage, since I think restructuring like this would have to be done at the end of the merge window to avoid major disruption to people working on this code.) Thanks for taking a look over it! Bjorn
