Hi Rob, On 13/04/2018 22:34, Rob Herring wrote: > On Tue, Apr 10, 2018 at 01:58:33PM +0100, Gustavo Pimentel wrote: >> Replaces "ctrlreg" reg-name by "dbi" to be coherent with similar drivers, >> however it still be compatible with any previous DT that uses the old >> reg-name. >> >> Replaces the PCIe base address example by a real PCIe base address in use. >> >> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx> >> --- >> Changes v1->v2: >> - Removed any iATU reference or changes to avoid confusion. >> - Add "snps,dw-pcie" compatible string following Kishon's suggestion. >> Changes v2->v3: >> - Nothing changed, just to follow the patch set version. >> >> Documentation/devicetree/bindings/pci/designware-pcie.txt | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt b/Documentation/devicetree/bindings/pci/designware-pcie.txt >> index 1da7ade..f02cd20 100644 >> --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt >> +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt >> @@ -1,7 +1,8 @@ >> * Synopsys DesignWare PCIe interface >> >> Required properties: >> -- compatible: should contain "snps,dw-pcie" to identify the core. >> +- compatible: >> + "snps,dw-pcie-rc", "snps,dw-pcie" for RC mode; > > I think adding this compatible is pointless. "snps,dw-pcie" meant RC and > should continue to mean that. We also have compatibles with the IP > version number as well as the SoC specific compatible strings. We don't > need 4 compatible strings here. Ok. > > Rob > Thanks, Gustavo
