Hi Lorenzo,
On 18-03-19 11:05 AM, Lorenzo Pieralisi wrote:
On Fri, Mar 16, 2018 at 02:53:16PM -0500, Rob Herring wrote:
On Wed, Mar 7, 2018 at 11:57 AM, Scott Branden
<scott.branden@xxxxxxxxxxxx> wrote:
Hi Rob,
Change to PCIE_IPROC_BCMA to be made.
On 18-03-07 07:42 AM, Rob Herring wrote:
Add COMPILE_TEST on driver config options with it. Some ARM drivers
still have arch dependencies, so we have to keep those dependent on ARM.
Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
---
drivers/pci/dwc/Kconfig | 24 ++++++++++++------------
drivers/pci/host/Kconfig | 33 +++++++++++++++------------------
2 files changed, 27 insertions(+), 30 deletions(-)
[...]
@@ -127,7 +126,7 @@ config PCIE_IPROC_PLATFORM
config PCIE_IPROC_BCMA
tristate "Broadcom iProc PCIe BCMA bus driver"
- depends on ARM && (ARCH_BCM_IPROC || COMPILE_TEST)
+ depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
select PCIE_IPROC
select BCMA
default ARCH_BCM_5301X
The was intentionally depending on ARM (as it does not apply to ARM64 which
ARCH_BCM__IPROC also applies to). Please keep that in place.
depends on (ARM && ARCH_BCM_IPROC) || COMPILE_TEST
Indeed.
Lorenzo, can you fix up or want me to send a new version?
Hi Rob,
I can fix it up, I am not sure where the dependency on ARM is though,
isn't patch 2 supposed to remove it ? I am certainly missing something
here so please chime in.
Thanks,
Lorenzo
You patch wanted to remove the dependency on ARM during COMPILE_TEST.
But, during normal use, it should not remove such dependency.
As such, the following is the correct change to make:
depends on (ARM && ARCH_BCM_IPROC) || COMPILE_TEST
Thanks,
Scott
