Re: [PATCH 7/9] PCI: improve host drivers compile test coverage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 7, 2018 at 11:57 AM, Scott Branden
<scott.branden@xxxxxxxxxxxx> wrote:
> Hi Rob,
>
> Change to PCIE_IPROC_BCMA to be made.
>
>
> On 18-03-07 07:42 AM, Rob Herring wrote:
>>
>> Add COMPILE_TEST on driver config options with it. Some ARM drivers
>> still have arch dependencies, so we have to keep those dependent on ARM.
>>
>> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
>> ---
>>   drivers/pci/dwc/Kconfig  | 24 ++++++++++++------------
>>   drivers/pci/host/Kconfig | 33 +++++++++++++++------------------
>>   2 files changed, 27 insertions(+), 30 deletions(-)

[...]

>> @@ -127,7 +126,7 @@ config PCIE_IPROC_PLATFORM
>>     config PCIE_IPROC_BCMA
>>         tristate "Broadcom iProc PCIe BCMA bus driver"
>> -       depends on ARM && (ARCH_BCM_IPROC || COMPILE_TEST)
>> +       depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
>>         select PCIE_IPROC
>>         select BCMA
>>         default ARCH_BCM_5301X
>
> The was intentionally depending on ARM (as it does not apply to ARM64 which
> ARCH_BCM__IPROC also applies to).  Please keep that in place.
> depends on (ARM && ARCH_BCM_IPROC) || COMPILE_TEST

Indeed.

Lorenzo, can you fix up or want me to send a new version?

Rob



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux