On 11/27/2017 3:56 AM, Joonas Lahtinen wrote: > On Thu, 2017-11-23 at 13:37 -0500, Sinan Kaya wrote: >> On 11/23/2017 2:42 AM, Joonas Lahtinen wrote: >>> It is not longer than 80 characters when you break line before the >>> PCI_DEVFN like I proposed. Or you can break it after the "=", too, >>> either way works fine. >> >> I posted V2 with this suggestion. >> >> https://patchwork.kernel.org/patch/10071759/ >> >> Let me know what you think about the domain number call here. >> >> u32 domain = pci_domain_nr(dev_priv->drm.pdev->bus); > > The function return signature is 'int' as well as the parameter in > pci_get_domain_bus_and_slot is type 'int', so why fight it and try to > make the variable 'u32'? Agreed. I made this change on V3. > >> I don't have a way to test this change. I traced the drm_device's pdev >> assignment in the code. It should work fine but I don't have a proof. > > Send the patch to intel-gfx@xxxxxxxxxxxxxxxxxxxxx and it should get > automatically tested by our CI system. Thanks, Let me post V3 and put this address on CC. > > Regards, Joonas > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
