On 11/23/2017 2:42 AM, Joonas Lahtinen wrote: > It is not longer than 80 characters when you break line before the > PCI_DEVFN like I proposed. Or you can break it after the "=", too, > either way works fine. I posted V2 with this suggestion. https://patchwork.kernel.org/patch/10071759/ Let me know what you think about the domain number call here. u32 domain = pci_domain_nr(dev_priv->drm.pdev->bus); I don't have a way to test this change. I traced the drm_device's pdev assignment in the code. It should work fine but I don't have a proof. If you tell me for sure that this driver will never use a non-zero domain or this driver will never run on another architecture, I can hard-code it as 0 as well. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
