Re: [PATCH v2 0/5] PCI: xilinx: Cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 12, 2016 at 08:10:30AM -0500, Bjorn Helgaas wrote:
>   - Add local "dev" pointers to reduce repetition of things like
>     "&pdev->dev".
> 
>   - Remove platform drvdata because it appears unused (we called
>     platform_set_drvdata() but not platform_get_drvdata()).
> 
>   - Remove unused xilinx_pcie_assign_msi() argument.
> 
> Nothing here should change the behavior of the driver.
> 
> Changes from v1:
>   Added "PCI: xilinx: Removed unused xilinx_pcie_assign_msi() argument"
>   I dropped the following patches because they were a lot of churn for
>   questionable benefit:
>     PCI: xilinx: Name private struct pointer "xilinx" consistently
>     PCI: xilinx: Rename accessors
>     PCI: xilinx: Swap order of xilinx_writel() reg/val arguments
>     PCI: xilinx-nwl: Name private struct pointer "nwl" consistently
>     PCI: xilinx-nwl: Swap order of nwl_bridge_writel() reg/val arguments
> 
> ---
> 
> Bjorn Helgaas (5):
>       PCI: xilinx: Add local struct device pointers
>       PCI: xilinx: Remove unused platform data
>       PCI: xilinx: Removed unused xilinx_pcie_assign_msi() argument
>       PCI: xilinx-nwl: Add local struct device pointers
>       PCI: xilinx-nwl: Remove unused platform data

I applied these to pci/host-xilinx for v4.9.  I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux