Re: [PATCH v2 0/4] PCI: xgene: Cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 12, 2016 at 08:07:35AM -0500, Bjorn Helgaas wrote:
>   - Add local "dev" pointers to reduce repetition of things like
>     "&pdev->dev".
> 
>   - Remove platform drvdata because it appears unused (we called
>     platform_set_drvdata() but not platform_get_drvdata()).
> 
>   - Pass the struct xgene_pcie_port pointer, not addresses, to setup
>     functions to enable simplifications.
> 
>   - Add register accessors to encapsulate usage of port->csr_base a bit.
> 
> Nothing here should change the behavior of the driver.
> 
> Changes from v1:
>   I dropped the following patch because it was a lot of churn for
>   questionable benefit:
>     PCI: xgene: Name private struct pointer "xgene" consistently
> 
> ---
> 
> Bjorn Helgaas (4):
>       PCI: xgene: Add local struct device pointers
>       PCI: xgene: Remove unused platform data
>       PCI: xgene: Pass struct xgene_pcie_port to setup functions
>       PCI: xgene: Add register accessors

I applied these to pci/host-xgene for v4.9.  I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux