On Thu, Oct 22, 2015 at 9:04 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > On Thu, Oct 22, 2015 at 11:04:26AM +0200, Lucas Stach wrote: >> I'm not sure if I like the removal of all the LTSSM state defines, as >> not all reference manuals include them and so I liked to have the header >> as a reference. But if you prefer to not carry unused defines in the >> kernel I won't object strongly to the removal. >> >> Otherwise the series looks fine, which you may take as a Reviewed-by. > > Thanks, Lucas. > > OK, I put the rest of the LTSSM #defines back in > drivers/pci/host/pcie-designware.h as a separate patch (below): > Thanks for putting it back. Its useful to debug issues related to link training, which one finds many a time with new silicon. And as Lucas pointed, its not mentioned in most of the user manual. I remember, I had to grep it into RTL code :(. For the series Acked-by: Pratyush Anand <pratyush.anand@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html