Re: [PATCH v4 0/4] PCI: designware: LTSSM #define cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bjorn,

Am Mittwoch, den 21.10.2015, 13:42 -0500 schrieb Bjorn Helgaas:
> This is a revision of Fabio's series:
> http://lkml.kernel.org/r/1444664808-16445-1-git-send-email-festevam@xxxxxxxxx
> 
> Lucas, you reviewed the v3 patches, but I fiddled enough with this that I
> didn't want to blindly carry your review forward.  I don't *think* I
> changed anything substantive, but I might have missed something.
> 
I'm not sure if I like the removal of all the LTSSM state defines, as
not all reference manuals include them and so I liked to have the header
as a reference. But if you prefer to not carry unused defines in the
kernel I won't object strongly to the removal.

Otherwise the series looks fine, which you may take as a Reviewed-by.

Regards,
Lucas

> Changes since Fabio's v3:
>   - Split removal of spear unused #defines to separate patch
>   - Combine LTSSM_STATE_MASK definition and use changes in one patch
>   - Combine LTSSM_STATE_RCVRY_LOCK definition and use in one patch
>   - Use common LTSSM_STATE_L0 definition
> 
> ---
> 
> Bjorn Helgaas (1):
>       PCI: designware: Use common LTSSM_STATE_L0 definition
> 
> Fabio Estevam (3):
>       PCI: designware: Use common LTSSM_STATE_MASK definition
>       PCI: designware: Use common LTSSM_STATE_RCVRY_LOCK definition
>       PCI: spear: Remove unused #defines
> 
> 
>  drivers/pci/host/pci-imx6.c        |    3 +-
>  drivers/pci/host/pci-keystone-dw.c |    2 -
>  drivers/pci/host/pci-layerscape.c  |    4 +-
>  drivers/pci/host/pcie-designware.h |    4 ++
>  drivers/pci/host/pcie-spear13xx.c  |   70 ------------------------------------
>  5 files changed, 6 insertions(+), 77 deletions(-)

-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux