Hi Fabio:
> -----Original Message-----
> From: Zhu Richard-R65037
> Sent: Thursday, October 02, 2014 10:40 AM
> To: Fabio Estevam
> Cc: Zhu Richard-R65037; linux-pci-owner@xxxxxxxxxxxxxxx; linux-
> pci@xxxxxxxxxxxxxxx; Guo Shawn-R65073; Lucas Stach; Tim Harvey
> Subject: Re: [PATCH v4 10/10] ARM: imx6sx: enable pcie on imx6sx sdb board
>
> Yes, PCIE_PWR_EN would be added later.
> Thanks, Fabio.
>
> Best regards
> Richard
>
> > 在 2014年10月1日，上午12:21，"Fabio Estevam" <festevam@xxxxxxxxx> 写道：
> >
> > Hi Richard,
> >
> >> On Tue, Sep 30, 2014 at 6:36 AM, Richard Zhu <r65037@xxxxxxxxxxxxx> wrote:
> >> Signed-off-by: Richard Zhu <r65037@xxxxxxxxxxxxx>
> >> ---
> >> arch/arm/boot/dts/imx6sx-sdb.dts | 13 +++++++++++++
> >> 1 file changed, 13 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts
> >> b/arch/arm/boot/dts/imx6sx-sdb.dts
> >> index a3980d9..2976913 100644
> >> --- a/arch/arm/boot/dts/imx6sx-sdb.dts
> >> +++ b/arch/arm/boot/dts/imx6sx-sdb.dts
> >> @@ -251,6 +251,13 @@
> >> };
> >> };
> >>
> >> +&pcie {
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&pinctrl_pcie>;
> >> + reset-gpio = <&gpio2 0 0>;
> >> + status = "okay";
> >> +};
> >
> > There is also GPIO2_1 which is the PCIE_PWR_EN signal and should be
> > added as a GPIO controlled regulator.
[Richard] The GIPO controlled regulator is discarded in the latest kernel, it is pointed out by Lucas in the
previous review.
"
> @@ -502,6 +503,7 @@
> &pcie {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_pcie>;
> + power-on-gpio = <&gpio3 19 0>;
> reset-gpio = <&gpio7 12 0>;
> status = "okay";
> };
This hunk is wrong. There is no "power-on-gpio" in the binding anymore.
Also there is already a change in Shawns tree to model this as a always-on regulator. If we really want to control pci bus power this needs to be done through this regulator, not some arbitrary gpio hack.
"
Best Regards
Richard Zhu
?韬{.n?????%??檩??w?{.n???{炳???骅w* jg????????G??⒏ ⒎?:+v???????? ????＂??????
