On Mon, Jun 16, 2014 at 5:13 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> On Sat, Jun 14, 2014 at 8:18 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>> On Sat, Jun 14, 2014 at 2:21 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
>>> diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c
>>> index f44fdb5b0b08..18ac24d84f9b 100644
>>> --- a/drivers/pci/hotplug/pciehp_hpc.c
>>> +++ b/drivers/pci/hotplug/pciehp_hpc.c
>>> @@ -142,11 +143,24 @@ static void pcie_wait_cmd(struct controller *ctrl)
>>> if (ctrl->no_cmd_complete)
>>> return;
>>>
>>> + if (!ctrl->cmd_busy)
>>> + return;
>>
>> Can you move those two lines to second patch ?
>
> I moved them to the first patch ("Make pcie_wait_cmd()
> self-contained") since that is more concerned with cleaning up
> pcie_wait_cmd(). It could even be a separate patch; it would have
> made sense to check cmd_busy before calling pcie_wait_cmd(). But it
> seemed like overkill to make another patch just for that.
Agreed.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
