Re: [PATCH] PCI: don't UNSET resource even reassign fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 16, 2014 at 11:44 PM, Guo Chao <yan@xxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Jun 16, 2014 at 02:44:34PM -0600, Bjorn Helgaas wrote:
>> On Mon, Jun 16, 2014 at 5:29 AM, Guo Chao <yan@xxxxxxxxxxxxxxxxxx> wrote:
>> > Commit bd064f0a sets IORESOURCE_UNSET flag if resource can not be
>> > assgined. Part of these changes breaks resource assignment.
>> >
>> > If resource is too big, PCI core assgins basic part first and
>> > extends (reassigns) it to include optional part (notably SR-IOV resources).
>> > In this case, failure is permitted and IORESOURCE_UNSET should be not set.
>> > Otherwise, these resources are never updated to hardware even they are
>> > already propery assigned and we will see errors like this:
>> >
>> >         pci 0003:00:00.0: can't enable device: BAR 15 [mem size 0x0c000000 64bit pref] not assigned
>> >         pci 0003:00:00.0: Error enabling bridge (-22), continuing
>>
>> Please attach a complete dmesg log so I can look at this in more
>> detail.  Thanks!
>>
>
> It again appeared in the new machine and cards so it may not proper to
> send complete dmesg in public list. Attachment is an excerpt related to
> resource assignment.

Just remove the identifying information like vendor/device IDs and
dmidecode info.  You can use something like this to make it easy:

dmesg | sed -r 's/(pci ....:..:..\..:
\[)....:....(\].*)/\1VVVV:DDDD\2/' | sed -r 's/(DMI:).*/\1 (removed)/'

I still want to see the details about the kernel version, host bridge,
device enumeration, initial BAR values, BAR sizing, bridge topology,
etc.  It makes more work for me when people extract out the things
they think I should be interested in because I'm interested in lots of
things, and sometimes I don't even know all those things until I see
them.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux