Hello Bjørn Erik Nilsen, > -----Original Message----- > From: Jingoo Han [mailto:jg1.han@xxxxxxxxxxx] > Sent: Thursday, December 05, 2013 7:55 AM > To: 'Bjorn Helgaas' > Cc: 'Marek Vasut'; 'Bjørn Erik Nilsen'; 'Pratyush Anand'; linux- > pci@xxxxxxxxxxxxxxx; 'Kishon Vijay Abraham I'; Mohit KUMAR DCG; Ajay > KHANDELWAL; 'Tim Harvey'; 'Eric Nelson'; 'Troy Kisky'; 'Jingoo Han' > Subject: Re: [PATCH v5 0/2] Kernel oops from pci_disable_msi > > On Thursday, December 05, 2013 11:19 AM, Marek Vasut wrote: > > On Thursday, December 05, 2013 at 02:52:38 AM, Jingoo Han wrote: > > > On Friday, November 29, 2013 10:35 PM, Bjørn Erik Nilsen wrote: > > > > This patchset address Marek Vasut's comments on the previous > > > > patches. I decided to split into two separate commits as they are > > > > unrelated. > > > > > > > > Bjørn Erik Nilsen (2): > > > > PCI: designware: Fix crash in dw_msi_teardown_irq > > > > PCI: designware: Remove redundant call to pci_write_config > > > > > > > > drivers/pci/host/pcie-designware.c | 57 > > > > +++++++++++++++++++++++++++----------- 1 file changed, 41 > > > > insertions(+), 16 deletions(-) > > > > > > I tested these patches on Exynos platform, and checked that the > > > kernel panic was resolved. > > > > > > Marek Vasut, Bjørn Erik Nilsen, > > > Is there any issue for accepting these patches? > > > > No issue on my end. > > > > Acked-by: Marek Vasut <marex@xxxxxxx> > > Acked-by: Jingoo Han <jg1.han@xxxxxxxxxxx> > I tested it on SPEAr1310 platform and no kernel panic is found. Tested-by: Mohit Kumar <mohit.kumar@xxxxxx> As 'write_msi_msg()' redundant call is removed so the following comment messages are not required here: /* * write_msi_msg() will update PCI_MSI_FLAGS so there is * no need to explicitly call pci_write_config. */ Instead move it to the commit log. Same for the other patch for dw_msi_teardown_irq(). Thanks Mohit -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
