> -----Original Message----- > From: Ben Hutchings [mailto:bhutchings@xxxxxxxxxxxxxx] > Sent: Wednesday, September 19, 2012 6:23 PM > To: Yinghai Lu > Cc: Bjorn Helgaas; Rose, Gregory V; Yuval Mintz; davem@xxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; Ariel Elior; Eilon Greenstein; linux-pci > Subject: Re: New commands to configure IOV features > > On Wed, 2012-09-19 at 17:19 -0700, Yinghai Lu wrote: > > On Wed, Sep 19, 2012 at 3:46 PM, Ben Hutchings > > <bhutchings@xxxxxxxxxxxxxx> wrote: > > > On Wed, 2012-09-19 at 15:17 -0700, Yinghai Lu wrote: > > >> +max_vfs_store(struct device *dev, struct device_attribute *attr, > > >> + const char *buf, size_t count) { > > >> + unsigned long val; > > >> + struct pci_dev *pdev = to_pci_dev(dev); > > >> + > > >> + if (strict_strtoul(buf, 0, &val) < 0) > > >> + return -EINVAL; > > >> + > > >> + pdev->max_vfs = val; > > >> + > > >> + return count; > > >> +} > > > [...] > > > > > > Then what would actually trigger creation of the VFs? There's no > > > way we can assume that some sysfs attribute will be written before > > > the PF driver is loaded (what if it's built-in?). I thought the > > > idea was to add a driver callback that would be called when the > > > sysfs attribute was written. > > > > could just stop the device and add it back again? > > This is highly disruptive and I think it would be totally unacceptable for > at least networking devices. Agreed. We need the driver callback. - Greg ��.n��������+%������w��{.n�����{���"�)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
