On Wed, 2012-09-19 at 17:19 -0700, Yinghai Lu wrote:
> On Wed, Sep 19, 2012 at 3:46 PM, Ben Hutchings
> <bhutchings@xxxxxxxxxxxxxx> wrote:
> > On Wed, 2012-09-19 at 15:17 -0700, Yinghai Lu wrote:
> >> +max_vfs_store(struct device *dev, struct device_attribute *attr,
> >> + const char *buf, size_t count)
> >> +{
> >> + unsigned long val;
> >> + struct pci_dev *pdev = to_pci_dev(dev);
> >> +
> >> + if (strict_strtoul(buf, 0, &val) < 0)
> >> + return -EINVAL;
> >> +
> >> + pdev->max_vfs = val;
> >> +
> >> + return count;
> >> +}
> > [...]
> >
> > Then what would actually trigger creation of the VFs? There's no way we
> > can assume that some sysfs attribute will be written before the PF
> > driver is loaded (what if it's built-in?). I thought the idea was to
> > add a driver callback that would be called when the sysfs attribute was
> > written.
>
> could just stop the device and add it back again?
This is highly disruptive and I think it would be totally unacceptable
for at least networking devices.
Ben.
> just like updated patch.
>
> Thanks
>
> Yinghai
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
