On Fri, Feb 28, 2025 at 04:26:23AM +0530, Krishna Chaitanya Chundru wrote: > > > On 2/25/2025 6:53 PM, Rob Herring (Arm) wrote: > > > > On Tue, 25 Feb 2025 15:03:58 +0530, Krishna Chaitanya Chundru wrote: > > > From: Krishna chaitanya chundru <quic_krichai@xxxxxxxxxxx> > > > > > > Add a device tree binding for the Toshiba TC956x PCIe switch, which > > > provides an Ethernet MAC integrated to the 3rd downstream port and two > > > downstream PCIe ports. > > > > > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@xxxxxxxxxxx> > > > Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx> > > > --- > > > .../devicetree/bindings/pci/toshiba,tc956x.yaml | 178 +++++++++++++++++++++ > > > 1 file changed, 178 insertions(+) > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Warning: Duplicate compatible "pciclass,0604" found in schemas matching "$id": > > http://devicetree.org/schemas/pci/toshiba,tc956x.yaml# > > http://devicetree.org/schemas/pci/pci-pci-bridge.yaml# > Hi Rob, > > As we want to refernce pci-pci-bridge.yaml which is expecting compatible > as "pciclass,0604", we modified the compatible as "pci1179,0623", > "pciclass,0604". Now adding pciclass0604 is giving this warning. can you > suggest correct way to represent this. > I think the PCI-PCI bridge compatible should be part of the actual bridge nodes inside the switch. I still stand by my view that the bridge compatible doesn't make sense for the top level switch node as this switch is a sort of MFD. So you should do: pcie@0,0 { compatible = "pci1179,0623"; reg = <0x10000 0x0 0x0 0x0 0x0>; ... pcie@1,0 { compatible = "pciclass,0604"; reg = <0x20800 0x0 0x0 0x0 0x0>; ... }; }; - Mani -- மணிவண்ணன் சதாசிவம்
