On Sat, Feb 01, 2025 at 01:14:20PM +0100, Stefan Wahren wrote:
> The entering of L23 lower-power state is optional, because the
> connected endpoint might doesn't support it. So pcie-brcmstb shouldn't
> print an error if it fails.
>
Which part of the PCIe spec states that the L23 Ready state is optional?
- Mani
> Signed-off-by: Stefan Wahren <wahrenst@xxxxxxx>
> ---
> drivers/pci/controller/pcie-brcmstb.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
> index e733a27dc8df..9e7c5349c6c2 100644
> --- a/drivers/pci/controller/pcie-brcmstb.c
> +++ b/drivers/pci/controller/pcie-brcmstb.c
> @@ -1399,7 +1399,10 @@ static void brcm_pcie_remove_bus(struct pci_bus *bus)
> pcie->sr = NULL;
> }
>
> -/* L23 is a low-power PCIe link state */
> +/*
> + * Try to enter L23 ( low-power PCIe link state )
> + * This might fail if connected endpoint doesn't support it.
> + */
> static void brcm_pcie_enter_l23(struct brcm_pcie *pcie)
> {
> void __iomem *base = pcie->base;
> @@ -1422,7 +1425,7 @@ static void brcm_pcie_enter_l23(struct brcm_pcie *pcie)
> }
>
> if (!l23)
> - dev_err(pcie->dev, "failed to enter low-power link state\n");
> + dev_dbg(pcie->dev, "Unable to enter low-power link state\n");
> }
>
> static int brcm_phy_cntl(struct brcm_pcie *pcie, const int start)
> --
> 2.34.1
>
>
--
மணிவண்ணன் சதாசிவம்
