Re: [v11 2/2] misc: pci_endpoint_test: Fix overflow of bar_size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

> > Since you have already applied this series, with my comment fixed up,
> > could your perhaps add the following (or similar) to the commit message
> > in patch 2/2:
> > 
> > 
> > "
> > By changing the type to resource_size_t, which is a typedef to phys_addr_t,
> > which can be 64-bit in certain configurations (e.g. X86_PAE selects
> > PHYS_ADDR_T_64BIT), even when the compiler is 32-bit. Thus, we also need to
> > change the division to do_div(), to properly perform a 64-bit division when
> > the compiler is 32-bit.
> > "
> 
> s/do_div()/div_u64()/

Will do.  Sounds good!

Thank you!

	Krzysztof




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux