On Thu, Jan 16, 2025 at 10:36:18AM +0100, Niklas Cassel wrote: > Hello Krzysztof, > > On Thu, Jan 16, 2025 at 11:03:00AM +0900, Krzysztof Wilczyński wrote: > > Hello, > > > > > I intended to stay silent, but considering that Mani gave additional > > > feedback: > > > > I am glad you didn't as feedback is always appreciated. :) > > > > > - The Suggested-by tag should be in patch 1/2, not 2/2 :) > > > (Patch 2/2 was 100% you.) > > > > I moved the Suggested-by tag around the correct patch. > > > > Thank you! > > > > Krzysztof > > Since you have already applied this series, with my comment fixed up, > could your perhaps add the following (or similar) to the commit message > in patch 2/2: > > > " > By changing the type to resource_size_t, which is a typedef to phys_addr_t, > which can be 64-bit in certain configurations (e.g. X86_PAE selects > PHYS_ADDR_T_64BIT), even when the compiler is 32-bit. Thus, we also need to > change the division to do_div(), to properly perform a 64-bit division when > the compiler is 32-bit. > " s/do_div()/div_u64()/ Kind regards, Niklas
