Re: [v11 2/2] misc: pci_endpoint_test: Fix overflow of bar_size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Hans,

On Wed, Jan 15, 2025 at 10:28:42PM +0530, Manivannan Sadhasivam wrote:
> On Thu, Jan 09, 2025 at 05:45:56PM +0800, Hans Zhang wrote:
> > With 8GB BAR2, running pcitest -b 2 fails with "TEST FAILED".
> > 
> > The return value of the `pci_resource_len` interface is not an integer.
> > Using `pcitest` with an 8GB BAR2, the bar_size of integer type will
> > overflow.
> > 
> > Change the data type of bar_size from integer to resource_size_t, to fix
> > the above issue.
> > 
> > Signed-off-by: Hans Zhang <18255117159@xxxxxxx>
> > Suggested-by: Niklas Cassel <cassel@xxxxxxxxxx>

I intended to stay silent, but considering that Mani gave additional
feedback:

- The Suggested-by tag should be in patch 1/2, not 2/2 :)
  (Patch 2/2 was 100% you.)

- No need to keep the change log all the way back since V1, usually
  people just keep the change log since the last revision.


Kind regards,
Niklas




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux