On Wed, Mar 27, 2024 at 03:01:08PM +0530, Siddharth Vadapalli wrote: > On Tue, Mar 26, 2024 at 06:24:03PM -0500, Bjorn Helgaas wrote: > > On Tue, Mar 26, 2024 at 08:12:58PM +0530, Siddharth Vadapalli wrote: > > > In the process of converting .scan_bus() callbacks to .add_bus(), the > > > ks_pcie_v3_65_scan_bus() function was changed to ks_pcie_v3_65_add_bus(). > > > The .scan_bus() method belonged to ks_pcie_host_ops which was specific > > > to controller version 3.65a, while the .add_bus() method had been added > > > to ks_pcie_ops which is shared between the controller versions 3.65a and > > > 4.90a. Neither the older ks_pcie_v3_65_scan_bus() method, nor the newer > > > ks_pcie_v3_65_add_bus() method is applicable to the controller version > > > 4.90a which is present in AM654x SoCs. > > > > > > Thus, as a fix, move the contents of "ks_pcie_v3_65_add_bus()" to the > > > .msi_init callback "ks_pcie_msi_host_init()" which is specific to the > > > 3.65a controller. Also, move the definitions of ks_pcie_set_dbi_mode() > > > and ks_pcie_clear_dbi_mode() above ks_pcie_msi_host_init() in order to > > > avoid forward declaration. > > > > If it's possible to split this into two patches (one that strictly > > *moves* the code without otherwise changing it, and another that makes > > the actual fix), it would be easier to review the fix. It's a pain to > > have to compare the code in the old location with that in the new > > location. > > Sure. I will do so and post the v7 patch. I have posted the v7 series at: https://lore.kernel.org/r/20240328085041.2916899-1-s-vadapalli@xxxxxx/ Regards, Siddharth.
