On 27/03/2024 19:55, Bartosz Golaszewski wrote: > On Wed, Mar 27, 2024 at 7:17 PM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 25/03/2024 14:16, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> >>> >>> The QCA6390 package contains discreet modules for WLAN and Bluetooth. They >>> are powered by the Power Management Unit (PMU) that takes inputs from the >>> host and provides LDO outputs. This document describes this module. >>> >>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> >> >> Can you start using b4? >> >> This is a friendly reminder during the review process. >> >> It looks like you received a tag and forgot to add it. >> >> If you do not know the process, here is a short explanation: >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new >> versions, under or above your Signed-off-by tag. Tag is "received", when >> provided in a message replied to you on the mailing list. Tools like b4 >> can help here. However, there's no need to repost patches *only* to add >> the tags. The upstream maintainer will do that for tags received on the >> version they apply. >> >> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 >> >> If a tag was not added on purpose, please state why and what changed. >> > > As per the first sentence of the cover letter: I dropped review tags > from the patches that changed significantly while keeping them for > those that didn't. If there's a way to let your automation know about > this, please let me know/point me in the right direction because I > don't know about it. > I went through changelog and did not see any remarks that patch #1 changed. b4 diff tells me: not much changed. Same properties and you just do not require supplies on other variant. This is rather minor change - just see by yourself. Best regards, Krzysztof