On Fri, Jan 19, 2024 at 03:26:56PM +0200, Dmitry Baryshkov wrote:
> On Fri, 19 Jan 2024 at 15:00, Mrinmay Sarkar <quic_msarkar@xxxxxxxxxxx> wrote:
> >
> > From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> >
> > Add common helpers for getting the eDMA/HDMA max channel count.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > Signed-off-by: Mrinmay Sarkar <quic_msarkar@xxxxxxxxxxx>
> > ---
> > drivers/dma/dw-edma/dw-edma-core.c | 18 ++++++++++++++++++
> > drivers/pci/controller/dwc/pcie-designware.c | 6 +++---
> > include/linux/dma/edma.h | 14 ++++++++++++++
> > 3 files changed, 35 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> > index 7fe1c19..2bd6e43 100644
> > --- a/drivers/dma/dw-edma/dw-edma-core.c
> > +++ b/drivers/dma/dw-edma/dw-edma-core.c
> > @@ -902,6 +902,24 @@ static int dw_edma_irq_request(struct dw_edma *dw,
> > return err;
> > }
> >
> > +static u32 dw_edma_get_max_ch(enum dw_edma_map_format mf, enum dw_edma_dir dir)
> > +{
> > + if (mf == EDMA_MF_HDMA_NATIVE)
> > + return HDMA_MAX_NR_CH;
>
> This will break unless patch 5 is applied.
I believe you are referring to patch 4.
> Please move the
> corresponding definition to this path.
>
Right. But it can be fixed by reordering the patches.
Mrinmay, please move patch 4/6 ahead of this one.
- Mani
--
மணிவண்ணன் சதாசிவம்
