works fine too. No particular reason to keep it bool. Acked-by: Daire McNamara <daire.mcnamara@xxxxxxxxxxxxx> On Wed, 2022-04-20 at 08:58 +0200, Uwe Kleine-König wrote: > [You don't often get email from u.kleine-koenig@xxxxxxxxxxxxxx. Learn > why this is important at http://aka.ms/LearnAboutSenderIdentification > .] > > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > If the driver is configured as a module (after allowing this by > changing > PCIE_MICROCHIP_HOST from bool to tristate) the missing semicolon > makes the > compiler very unhappy. While there isn't a real problem as > MODULE_DEVICE_TABLE always evaluates to nothing for a built-in > driver, > do it right for consistency with other drivers. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > Hello, > > I wonder if there is a technical reason to have PCIE_MICROCHIP_HOST > (and > some others) only bool. With this patch applied the driver compiles > just > fine with PCIE_MICROCHIP_HOST=m. > > Best regards > Uwe > > drivers/pci/controller/pcie-microchip-host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-microchip-host.c > b/drivers/pci/controller/pcie-microchip-host.c > index 29d8e81e4181..4b1e130f88a3 100644 > --- a/drivers/pci/controller/pcie-microchip-host.c > +++ b/drivers/pci/controller/pcie-microchip-host.c > @@ -1115,7 +1115,7 @@ static const struct of_device_id > mc_pcie_of_match[] = { > {}, > }; > > -MODULE_DEVICE_TABLE(of, mc_pcie_of_match) > +MODULE_DEVICE_TABLE(of, mc_pcie_of_match); > > static struct platform_driver mc_pcie_driver = { > .probe = pci_host_common_probe, > -- > 2.35.1 >
