On 20/04/2022 06:58, Uwe Kleine-König wrote: > If the driver is configured as a module (after allowing this by changing > PCIE_MICROCHIP_HOST from bool to tristate) the missing semicolon makes the > compiler very unhappy. While there isn't a real problem as > MODULE_DEVICE_TABLE always evaluates to nothing for a built-in driver, > do it right for consistency with other drivers. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > Hello, > > I wonder if there is a technical reason to have PCIE_MICROCHIP_HOST (and > some others) only bool. With this patch applied the driver compiles just > fine with PCIE_MICROCHIP_HOST=m. > > Best regards > Uwe I know ~nothing about the PCI driver itself, but I don't see why it wouldn't work as a module. I gave it a try & nothing has blown up in my face so far...
