On Sep 6, 2011 1:47 PM, "Benjamin Herrenschmidt" <benh@xxxxxxxxxxxxxxxxxxx> wrote: > On Tue, 2011-09-06 at 12:12 -0700, Jon Mason wrote: >> > Are these typically hitting with the "performance" option ? IE. It >> make >> > sense to leave MRRS untouched in the "safe" case. >> >> The patch I sent out still used the "performance" option without >> modifying the default MRRS of the device. All that have tested it >> said that it resolves their issues. > > But that will cause other issues as I described, if the MRRS end up > larger than the MPS. IE. The MRRS of a device must be set to be lower or > equal to the MPS of that device (not of the parent btw) if we allow the > parent(s) to have a larger MPS. Yes, that is the hole. > I -did- hit a very real problem with adapters where that wasn't true. > > As for those users, are they all the same radeon ? hpsa users too. Also, some Dell servers are experiencing issues, but I am not sure what hardware is causing issue on those systems. Based on this thread, I believe the best way to move forward is to make the "safe" option the default and have it not set the MRRS. The "performance" option will set the MRRS. I will add a printk to notify the user of potential issues. Hopefully users will try this option and inform us of any issues encountered. Thoughts? Thanks, Jon > Cheers, > Ben. > > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
